Add icon visibility for actions enabled on "all" #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @makfe, could you include a gif of what this looks like? It will be useful for the release notes. |
mottosso
reviewed
Jan 5, 2021
| @@ -224,6 +224,8 @@ def data(self, index, role): | |||
|
|
|||
| # Context specific actions | |||
| for action in actions: | |||
| if action.on == "all": | |||
There was a problem hiding this comment.
Looks simple enough, I wonder why this wasn't already the case. :O Nice find.
|
@mottosso Thank you for your reply :) I have tried to keep the gif as simple as possible. Let me know if that will work. |
|
That's great. :) Keeping it small is always the hardest thing. I think this looks good, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #84.
Icons for actions enabled
on = "all"are made visible.As commented in the issue, the bug might have been introduced here 3c86cd6#diff-4e27d04248feb2897be1066c5a0234cb332f4a7029aa1d33255b9c5f75837e72L231
as before the icons visibility was on by default.
I was hesitant to change the default visibility, because I found it hard to test for all the possibilities.
Because of that, I explicitly added visibility for the on "all" actions.
Please let me know what you think.