Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset_iterator starts from the first validatorOrder value #114 #120 #121

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

RafaelVillar
Copy link
Contributor

Hello @mottosso

Here is the PR for issue #120

@mottosso
Copy link
Member

I've had a look at this and noticed a flaw in the design of the reset function. It's based on misunderstanding how the orders are interpreted, and how they represent not a starting point, but a range of values, and how that range is offset by 0.5. Tough one indeed. :(

I've added a comment to the offending line to help future readers. I did however write this on GitHub and did not test it. Could you let me know if this solves the issue for you @RafaelVillar?

@RafaelVillar
Copy link
Contributor Author

Hey @mottosso I gave the edits you made a test and it seems to have worked as expected. It Fixes the issue it seems.

Let me know when you roll it into master

@mottosso mottosso merged commit e94b3ef into pyblish:master Feb 1, 2021
@mottosso
Copy link
Member

mottosso commented Feb 1, 2021

@RafaelVillar All done, should be released as well as 0.8.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants