Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nightly dependancy workflow #296

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

BradyPlanden
Copy link
Member

Description

Fixes workflow deployed in #291.

Issue reference

Fixes #290

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@agriyakhetarpal
Copy link
Member

Should we add the automated issue action in a separate PR? I thought that you were going to do it in the same PR, but you merged it :) We can also do it later when PyBaMM gets ready with the nightlies.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.49%. Comparing base (37f00e4) to head (f0246fd).
Report is 20 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #296   +/-   ##
========================================
  Coverage    95.49%   95.49%           
========================================
  Files           38       38           
  Lines         2040     2040           
========================================
  Hits          1948     1948           
  Misses          92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden
Copy link
Member Author

Fair shout, I'm happy for it to be added here and we can update the PR (or create a new one). I wanted to get the workflow in before travelling next week so pushed it through. At least now something is in a develop. Apologies for the quick trigger!

@agriyakhetarpal
Copy link
Member

No worries! I think we can merge this one – I'll create a new PR and add it there.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, forgot to add my above comment as a review. Already approved from my end :) thanks!

@BradyPlanden BradyPlanden merged commit 6ba3d04 into develop Apr 18, 2024
28 of 34 checks passed
@BradyPlanden BradyPlanden deleted the 290-test-nightly-against-pybamm-develop branch April 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test nightly against PyBaMM develop
2 participants