terminal/Terminal: work around xterm cursor style issue #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since updating to Blueprintjs 5.x we can get aliasing artifacts on the cursor due to bad rendering of box-shadow. This overrides it with border instead. xtermjs/xterm.js#4580
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1883 +/- ##
==========================================
+ Coverage 72.47% 72.53% +0.05%
==========================================
Files 201 201
Lines 5097 5097
Branches 1074 1074
==========================================
+ Hits 3694 3697 +3
+ Misses 1366 1363 -3
Partials 37 37
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since updating to Blueprintjs 5.x we can get aliasing artifacts on the cursor due to bad rendering of box-shadow. This overrides it with border instead.
xtermjs/xterm.js#4580