Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pkcs12 parse ordering. fixes #5872 #5879

Merged
merged 6 commits into from
Feb 28, 2021
Merged

Conversation

reaperhulk
Copy link
Member

No description provided.

alex
alex previously approved these changes Feb 28, 2021
alex
alex previously approved these changes Feb 28, 2021
@alex
Copy link
Member

alex commented Feb 28, 2021

tests/hazmat/primitives/test_pkcs12.py:289: error: Argument 1 to "generate_private_key" has incompatible type "Type[SECP256R1]"; expected "EllipticCurve" [arg-type]

mypy failure!

@reaperhulk
Copy link
Member Author

Nice, mypy doing its job!

@alex alex merged commit e244913 into pyca:main Feb 28, 2021
@reaperhulk reaperhulk deleted the pkcs12-ordering branch February 28, 2021 22:17
tiran pushed a commit to tiran/cryptography that referenced this pull request Apr 23, 2021
* fix pkcs12 parse ordering. fixes pyca#5872

* remove an unneeded print

* simplify the test a bit more

* index

* black

* Update tests/hazmat/primitives/test_pkcs12.py

Co-authored-by: Alex Gaynor <[email protected]>

Co-authored-by: Alex Gaynor <[email protected]>
tiran pushed a commit to tiran/cryptography that referenced this pull request Apr 23, 2021
* fix pkcs12 parse ordering. fixes pyca#5872

* remove an unneeded print

* simplify the test a bit more

* index

* black

* Update tests/hazmat/primitives/test_pkcs12.py

Co-authored-by: Alex Gaynor <[email protected]>

Co-authored-by: Alex Gaynor <[email protected]>
tiran pushed a commit to tiran/cryptography that referenced this pull request May 11, 2021
* fix pkcs12 parse ordering. fixes pyca#5872

* remove an unneeded print

* simplify the test a bit more

* index

* black

* Update tests/hazmat/primitives/test_pkcs12.py

Co-authored-by: Alex Gaynor <[email protected]>

Co-authored-by: Alex Gaynor <[email protected]>
tiran pushed a commit to tiran/cryptography that referenced this pull request Aug 16, 2021
* fix pkcs12 parse ordering. fixes pyca#5872

* remove an unneeded print

* simplify the test a bit more

* index

* black

* Update tests/hazmat/primitives/test_pkcs12.py

Co-authored-by: Alex Gaynor <[email protected]>

Co-authored-by: Alex Gaynor <[email protected]>
vishwin pushed a commit to vishwin/py-cryptography that referenced this pull request Dec 24, 2022
* fix pkcs12 parse ordering. fixes pyca#5872

* remove an unneeded print

* simplify the test a bit more

* index

* black

* Update tests/hazmat/primitives/test_pkcs12.py

Co-authored-by: Alex Gaynor <[email protected]>

Co-authored-by: Alex Gaynor <[email protected]>
aeeaan pushed a commit to aeeaan/cryptography that referenced this pull request Aug 10, 2024
* fix pkcs12 parse ordering. fixes pyca#5872

* remove an unneeded print

* simplify the test a bit more

* index

* black

* Update tests/hazmat/primitives/test_pkcs12.py

Co-authored-by: Alex Gaynor <[email protected]>

Co-authored-by: Alex Gaynor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants