Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose OP_NO_TLSv1_3 #861

Merged
merged 2 commits into from
Aug 2, 2019
Merged

Expose OP_NO_TLSv1_3 #861

merged 2 commits into from
Aug 2, 2019

Conversation

njsmith
Copy link
Contributor

@njsmith njsmith commented Aug 2, 2019

Fixes #624

@@ -139,6 +140,7 @@ class _buffer(object):
OP_NO_TLSv1 = _lib.SSL_OP_NO_TLSv1
OP_NO_TLSv1_1 = _lib.SSL_OP_NO_TLSv1_1
OP_NO_TLSv1_2 = _lib.SSL_OP_NO_TLSv1_2
OP_NO_TLSv1_3 = _lib.SSL_OP_NO_TLSv1_3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This symbol isn't going to exist on OpenSSL<1.1.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex
Copy link
Member

alex commented Aug 2, 2019 via email

@njsmith
Copy link
Contributor Author

njsmith commented Aug 2, 2019

Oh, that's annoying. I even checked that ctx.set_options(0) was a no-op, so it would be safe to use unconditionally :-).

@alex alex merged commit a181373 into pyca:master Aug 2, 2019
@njsmith njsmith deleted the add-op-no-tls-v1-3 branch August 2, 2019 04:41
@njsmith
Copy link
Contributor Author

njsmith commented Aug 2, 2019

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to configure pyopenssl to negotiate TLS-1.2-or-worse?
2 participants