-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose OP_NO_TLSv1_3 #861
Expose OP_NO_TLSv1_3 #861
Conversation
src/OpenSSL/SSL.py
Outdated
@@ -139,6 +140,7 @@ class _buffer(object): | |||
OP_NO_TLSv1 = _lib.SSL_OP_NO_TLSv1 | |||
OP_NO_TLSv1_1 = _lib.SSL_OP_NO_TLSv1_1 | |||
OP_NO_TLSv1_2 = _lib.SSL_OP_NO_TLSv1_2 | |||
OP_NO_TLSv1_3 = _lib.SSL_OP_NO_TLSv1_3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This symbol isn't going to exist on OpenSSL<1.1.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cryptography already handles that case for us:
`_conditional.py` then removes it.
…On Fri, Aug 2, 2019 at 12:17 AM Nathaniel J. Smith ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/OpenSSL/SSL.py
<#861 (comment)>:
> @@ -139,6 +140,7 @@ class _buffer(object):
OP_NO_TLSv1 = _lib.SSL_OP_NO_TLSv1
OP_NO_TLSv1_1 = _lib.SSL_OP_NO_TLSv1_1
OP_NO_TLSv1_2 = _lib.SSL_OP_NO_TLSv1_2
+OP_NO_TLSv1_3 = _lib.SSL_OP_NO_TLSv1_3
Cryptography already handles that case for us:
https://github.com/pyca/cryptography/blob/c7681e80a68a97ba56453e7fbb960f0e59f4acad/src/_cffi_src/openssl/ssl.py#L839-L841
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#861?email_source=notifications&email_token=AAAAGBEB7T5XJW6OK6JCQM3QCOYNZA5CNFSM4II2G6OKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCALYTXY#discussion_r309976427>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAAGBC2RHORFXO4FDTE42LQCOYNZANCNFSM4II2G6OA>
.
--
All that is necessary for evil to succeed is for good people to do nothing.
|
Oh, that's annoying. I even checked that |
Thanks! |
Fixes #624