Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change error on empty subjectAltNames #67

Merged
merged 6 commits into from
Jan 14, 2024
Merged

Change error on empty subjectAltNames #67

merged 6 commits into from
Jan 14, 2024

Conversation

hynek
Copy link
Collaborator

@hynek hynek commented Jan 13, 2024 •
edited
Loading

fixes #66

cc @glyph @adiroiban

@hynek hynek force-pushed the catch-no-sans branch 2 times, most recently from 9425de3 to f3a498e Compare January 13, 2024 12:38
@hynek hynek mentioned this pull request Jan 13, 2024
Closed
@hynek hynek force-pushed the catch-no-sans branch 2 times, most recently from b172969 to fe8fe2d Compare January 13, 2024 12:51
adiroiban
adiroiban approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. Only minor comments.

tests/test_hazmat.py Outdated Show resolved Hide resolved
src/service_identity/hazmat.py Show resolved Hide resolved
@hynek hynek merged commit 0c81d1d into main Jan 14, 2024
21 checks passed
@hynek hynek deleted the catch-no-sans branch January 14, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiroiban adiroiban adiroiban approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise a CertificateError if the certificate has no subjectAltName.
2 participants
@hynek @adiroiban