Add requests as installation requirement #269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests is imported in
base_identity.py
but not required or documented for installation.Additionally there were some made to requests's responses around the time of 1.0.0. So if you find that you've got a project with an older version of requests and try to authenticate using the 'rackspace' authentication scheme:
In earlier versions of requests
json
was a dictionary. Updating requests solved this problem, but took some digging. It's simple to avoid by requiring a minimum version of the dependency.If it isn't suitable to require this dependency it would be good to document it somewhere.
Dupe of #268 which was made against the wrong branch.