Handle empty bodies in GET calls to cloud_dns #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally cloud dns API will return an empty body on a GET call. Retrying immediately usually resolves this, but in the case that doesn't work raise a specific exception. cloud dns manager and client both had their own GET calls, so both had to be replaced. Some tests were mocking an empty body for get calls, which started throwing exceptions with this new code, so those tests had to be adjusted to put in something for the body, even if it is not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally cloud dns API will return an empty body on a GET call.
Retrying immediately usually resolves this, but in the case that doesn't
work raise a specific exception.
cloud dns manager and client both had their own GET calls, so both had
to be replaced.
Some tests were mocking an empty body for get calls, which started
throwing exceptions with this new code, so those tests had to be
adjusted to put in something for the body, even if it is not used.