Files that are exactly the chunk size can be uploaded as is #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a file was uploaded as a single chunk if fsize < self.max_file_size This is wrong: files that are exactly the max_file_size can also be uploaded as a single chunk. The fix is to replace < with <=: fsize < self.max_file_size This bug is problematic when attempting to replicate pyrax's normal chunk uploading behavior, while still using pyrax to upload chunks.
EdLeafe
added a commit
that referenced
this pull request
Feb 7, 2014
Files that are exactly the chunk size can be uploaded as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a file was uploaded as a single chunk if
This is wrong: files that are exactly the max_file_size can also be
uploaded as a single chunk. The fix is to replace < with <=:
This bug is problematic when attempting to replicate pyrax's normal
chunk uploading behavior, while still using pyrax to upload chunks.
This is a resubmission of #270.