Removed the need to specify a tenant_id for authentication. #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occastionally, it is desirable to authenticate with an unscoped token in Keystone. This patch removes the need to specify a tenant_id when authenticating with a username and password or a token. To remove the necesity for a patch, some of the safegaurds were remove from base_identity. To Manually Test: 1) set_credentials with a username and password (do not specify a tenant_id). 2) Ensure that pyrax.identity.authenticated returns true. 3) Grab the auth_token from your previous authentication. 4) Unauthenticate your previous user. 5) Use auth_with_token. Do not specify a tenant_id. 6) Verify that the two tokens are not the same 7) Verify that pyrax.identity.authenticated still returns true A unit test was also provided for token based authentication testing. A unit test was removed that checked the raised error for missing tenant_id.
EdLeafe
added a commit
that referenced
this pull request
Apr 9, 2014
Removed the need to specify a tenant_id for authentication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occastionally, it is desirable to authenticate with an unscoped token in Keystone.
This patch removes the need to specify a tenant_id when authenticating with a username and password or a token.
To remove the necesity for a patch, some of the safegaurds were remove from base_identity.
To Manually Test:
A unit test was also provided for token based authentication testing.
A unit test was removed that checked the raised error for missing tenant_id.