Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds unit tests for retry decorator #8

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

rjvitorino
Copy link
Contributor

  • Implements tests for retry success scenario
  • Adds tests for eventual success after retries
  • Includes tests for retry exhausted cases
  • Adds tests for custom rate limit exception handling
  • Ensures tests cover the correct number of retry attempts

Addresses issue #1

- Implements tests for retry success scenario
- Adds tests for eventual success after retries
- Includes tests for retry exhausted cases
- Adds tests for custom rate limit exception handling
- Ensures tests cover the correct number of retry attempts

Addresses issue pydanny#1
Uses RETRIES as constant in one of the asserts (missing from previous commit)
Copy link
Owner

@pydanny pydanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate that you did this without mocks, which is what I was planning to do. There's a lot of clarity and precision in this approach. 👍🏻

@pydanny pydanny merged commit 0d2368b into pydanny:main Jun 11, 2024
@rjvitorino rjvitorino deleted the feature/1-add-tests branch July 10, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants