Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade "inline-snapshot" #657

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Upgrade "inline-snapshot" #657

merged 2 commits into from
Jan 15, 2025

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Jan 10, 2025

Should now be working.


DO NOT MERGE

This is the result of running just

uv lock --upgrade-package 'inline-snapshot==0.15'
make install

E.g. we're just upgrading inline-snapshot from 0.14 to 0.15.

Two things break:

  • time taken to run tests goes from ~15s to ~250s!
  • lots of tests start failing mostly those that use our IsNow

@samuelcolvin
Copy link
Member Author

Odd - in CI tests are now slower as they are locally, just a few tests are failing.

Copy link

cloudflare-workers-and-pages bot commented Jan 15, 2025

Deploying pydantic-ai with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7514913
Status: ✅  Deploy successful!
Preview URL: https://5a121a56.pydantic-ai.pages.dev
Branch Preview URL: https://uprev-inline-snapshot.pydantic-ai.pages.dev

View logs

@samuelcolvin samuelcolvin marked this pull request as ready for review January 15, 2025 19:53
@samuelcolvin samuelcolvin changed the title try to upgrade "inline-snapshot" Upgrade "inline-snapshot" Jan 15, 2025
@samuelcolvin samuelcolvin merged commit 1e833ea into main Jan 15, 2025
14 checks passed
@samuelcolvin samuelcolvin deleted the uprev-inline-snapshot branch January 15, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant