test: added Is() to changed source code #658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/conftest.py
Outdated
| # return OldIsNow(*a,**ka,delta=50) | ||
|
|
||
| # 16 sec | ||
| return dirty_equals.AnyThing() |
There was a problem hiding this comment.
@15r10nk what if we got rid of the use of IsNow() and just did timestamp=dirty_equals.AnyThing()? Would that help?
There was a problem hiding this comment.
I would not remove all IsNow()s from the tests yet. I think there is some bug inside inline-snapshot which causes this and I want to try to fix it first.
But you can use the workaround above for now if you want.
15r10nk
force-pushed
the
uprev-inline-snapshot
branch
from
4b9c1f0 to
d14da39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.