Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic in validate_assignment when field has gone missing #1532

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Classic use of .unwrap() not being what we want! 😬

Related issue number

Fixes #1516

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Nov 4, 2024

CodSpeed Performance Report

Merging #1532 will not alter performance

Comparing dh/validate-assigment-crash (c554f08) with main (815d224)

Summary

✅ 155 untouched benchmarks

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks!

@sydney-runkle sydney-runkle merged commit 4cb82bf into main Nov 5, 2024
29 checks passed
@sydney-runkle sydney-runkle deleted the dh/validate-assigment-crash branch November 5, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust stacktraces and panics with validate_assignment and custom fields
2 participants