Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support trailing-strings with allow_partial #1539

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin
Copy link
Member Author

@davidhewitt I don't understand the stubs signature comparison error, could you have a look?

Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #1539 will not alter performance

Comparing allow_partial-trailing-strings (881dfe1) with main (a3f13c7)

Summary

✅ 155 untouched benchmarks

@samuelcolvin
Copy link
Member Author

well I know understand why this is not failing for from_json, we explicitly skip it:

pydantic_core._pydantic_core.from_json

@davidhewitt it would be very unfortunate to skip these methods as they're the key pydantic_core api, any ideas how to work around this?

@samuelcolvin
Copy link
Member Author

@sydney-runkle I think this is ready.

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@sydney-runkle sydney-runkle merged commit be03c66 into main Nov 12, 2024
28 of 29 checks passed
@sydney-runkle sydney-runkle deleted the allow_partial-trailing-strings branch November 12, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants