-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: New type ISBN #116
Add: New type ISBN #116
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 10 +1
Lines 642 688 +46
Branches 159 176 +17
=========================================
+ Hits 642 688 +46 ☔ View full report in Codecov by Sentry. |
please review |
hey @lucasmucidas can you fix the formatting issue in the code 🙏🏻 |
Sorry @yezz123, i think that's ok rn. About the docs on pydantic main repo: What should i do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implementation of issue-115
ISBN
The
pydantic_extra_types.isbn
module provides functionality to receive and validate ISBN(International Standard Book Number) in 10-digit and 13-digit formats. The output is always ISBN-13.
Using
output:
#> isbn='9788537809662'
Coverage
Selected Reviewer: @yezz123