Add back Python 3.8 support #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gospodima
reviewed
Dec 20, 2024
| @@ -107,9 +107,9 @@ class SomeModel(BaseModel): | |||
| us_number: USNumberType | |||
| """ | |||
|
|
|||
| default_region: Optional[str] = None | |||
| default_region: str | None = None | |||
There was a problem hiding this comment.
I am not a maintainer but went into this PR from the referenced issue.
As far as I know | can be used as Union or Optional alternative only from python 3.10, see Union Type and corresponding note at the end:
Added in version 3.10.
There was a problem hiding this comment.
Yeah, but | was proposed in PEP 604, I don't see it in PEP 563
There was a problem hiding this comment.
The PEP 563 future statement stringifies type annotations by default. See the note in https://typing.readthedocs.io/en/latest/guides/modernizing.html#introduction explaining what it enables
Kludex
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #248