Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout #790

Merged
merged 1 commit into from
Jul 6, 2020
Merged

add timeout #790

merged 1 commit into from
Jul 6, 2020

Conversation

JesseAldridge
Copy link
Contributor

@JesseAldridge JesseAldridge commented Jun 18, 2020

  • closes Timeout not actually used #789
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • passes black --check pandas_datareader
  • added entry to docs/source/whatsnew/vLATEST.txt

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2020

Codecov Report

Merging #790 into master will decrease coverage by 12.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #790       +/-   ##
===========================================
- Coverage   83.00%   70.80%   -12.21%     
===========================================
  Files          62       62               
  Lines        2860     2860               
  Branches      309      309               
===========================================
- Hits         2374     2025      -349     
- Misses        410      756      +346     
- Partials       76       79        +3     
Impacted Files Coverage Δ
pandas_datareader/base.py 86.02% <100.00%> (ø)
pandas_datareader/av/forex.py 27.65% <0.00%> (-68.09%) ⬇️
pandas_datareader/quandl.py 30.95% <0.00%> (-61.91%) ⬇️
pandas_datareader/tests/test_quandl.py 42.59% <0.00%> (-57.41%) ⬇️
pandas_datareader/av/time_series.py 41.86% <0.00%> (-53.49%) ⬇️
pandas_datareader/tiingo.py 42.57% <0.00%> (-53.47%) ⬇️
pandas_datareader/tests/av/test_av_time_series.py 30.76% <0.00%> (-51.65%) ⬇️
pandas_datareader/tests/av/test_av_forex.py 58.06% <0.00%> (-41.94%) ⬇️
pandas_datareader/enigma.py 23.63% <0.00%> (-41.82%) ⬇️
pandas_datareader/tests/test_tiingo.py 59.61% <0.00%> (-40.39%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e452bf8...4a38041. Read the comment docs.

@bashtage bashtage merged commit 375ffe2 into pydata:master Jul 6, 2020
@bashtage
Copy link
Contributor

bashtage commented Jul 6, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout not actually used
3 participants