Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing sphinx testing dependencies #1751

Merged
merged 7 commits into from
Apr 3, 2024
Merged

fix missing sphinx testing dependencies #1751

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
81b283c
fix missing sphinx testing dependencies
drammock Mar 29, 2024
0c94e20
do the specifier correctly
drammock Mar 29, 2024
0fba9e6
fix quoting
drammock Mar 29, 2024
775afd2
fix again
drammock Mar 29, 2024
8aa41cd
try another way
drammock Mar 29, 2024
830e677
try quoting again
drammock Mar 29, 2024
63d8462
try without whitespace
drammock Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tools/github_actions_install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ export PYTHONUTF8=1
if [[ "$SPHINX_VERSION" == "" ]]; then
SPHINX_INSTALL=""
elif [[ "$SPHINX_VERSION" == "dev" ]]; then
SPHINX_INSTALL="git+https://github.com/sphinx-doc/sphinx"
SPHINX_INSTALL="sphinx[test]@https://codeload.github.com/sphinx-doc/sphinx/zip/refs/heads/master"
elif [[ "$SPHINX_VERSION" == "old" ]]; then
SPHINX_INSTALL="sphinx==6.1.0"
SPHINX_INSTALL="sphinx[test]==6.1.0"
else # not used currently but easy enough
SPHINX_INSTALL="sphinx==$SPHINX_VERSION"
SPHINX_INSTALL="sphinx[test]==$SPHINX_VERSION"
fi
set -x # print commands
python -m pip install --upgrade pip wheel setuptools
python -m pip install -e .["$1"] ${SPHINX_INSTALL} $2 $DEP_EXTRA
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI $DEP_EXTRA is probably cruft from whoever we copied this file from. It's never used by us.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave it for now 🤷🏽‍♀️ the whole thing needs an overhaul

python -m pip install -e .["$1"] ${SPHINX_INSTALL} $2
Loading