-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI - Swap to trusted publisher for releases #1758
Conversation
WDYT about a step for building and checking the wheels with |
I can do that, I actually thought about it as I was working on #1759 |
ooh, I only looked quickly but that does seem useful! |
I have now added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonderful, thanks @trallard
@trallard I think maybe this PR isn't working as intended. Even after ditching Codecov so that the tests all pass (prerequisite for even running the build/upload workflow), the upload step is failing: https://github.com/pydata/pydata-sphinx-theme/actions/runs/8944060825/job/24570535182#step:3:51 If I'm reading the output of prior steps correctly, the artifact is actually named |
* 👷 Remove token based release from CI * Add package inspection step
Closes #1754
I only modified the
publish.yml
workflow in this PR to remove the token.Separately, I already added this as a trusted publisher in PyPI.