Fix translator_setup: undefined default_translator_class for linkcheck builder #2029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The translator setup is called unconditionally to add the HootstrapHTML5TransatorMixin. If no translators have been set explicitly this falls back to
app.builder.default_translator_class
, which is however not defined for thelinkcheck
builder (maybe others), resulting in an attribute error:This PR adds a safe check for
app.builder.default_translator_class
and skips the translator setup if the attribute is not defined.I have tested the modified version with
linkcheck
, but I am not sure where to add a unit test for these changes.