Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (responsive) navbar dropdown menu #313

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Fix (responsive) navbar dropdown menu #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a6bda1
Fix responsive navbar dropdown menu
jorisvandenbossche Feb 1, 2021
bfac8a9
fix height of navbar-brand
jorisvandenbossche Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ndex.951c8c8e3af89de180a2f03968e0e7cb.css → ...ndex.361b90cc13c3b373e3e2df043d87d1bd.css
View file
Open in desktop

Large diffs are not rendered by default.

0 ...e/static/js/index.014cad6f3a039303089e.js → ...e/static/js/index.4bc14ce28f4cf826ca84.js
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions pydata_sphinx_theme/static/webpack-macros.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@

{% macro head_pre_bootstrap() %}
<link href="{{ pathto('_static/css/theme.css', 1) }}" rel="stylesheet" />
<link href="{{ pathto('_static/css/index.951c8c8e3af89de180a2f03968e0e7cb.css', 1) }}" rel="stylesheet" />
<link href="{{ pathto('_static/css/index.361b90cc13c3b373e3e2df043d87d1bd.css', 1) }}" rel="stylesheet" />
{% endmacro %}

{% macro head_js_preload() %}
<link rel="preload" as="script" href="{{ pathto('_static/js/index.014cad6f3a039303089e.js', 1) }}">
<link rel="preload" as="script" href="{{ pathto('_static/js/index.4bc14ce28f4cf826ca84.js', 1) }}">
{% endmacro %}

{% macro body_post() %}
<script src="{{ pathto('_static/js/index.014cad6f3a039303089e.js', 1) }}"></script>
<script src="{{ pathto('_static/js/index.4bc14ce28f4cf826ca84.js', 1) }}"></script>
{% endmacro %}
5 changes: 2 additions & 3 deletions src/scss/_navbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
.navbar {
position: fixed;
height: var(--header-height);
min-height: var(--header-height);
width: 100%;
padding: 0;
overflow: hidden;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did this addition come from? we should make sure it wasn't fixing a different bug or something

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added in #286 (comment), but I don't directly know why it would have been necessary (I tested a few of the targets that #286 was fixing, and they still seem to be working)


.container-xl {
height: 100%;
Expand All @@ -12,7 +11,7 @@

.navbar-brand {
position: relative;
height: 100%;
height: var(--header-height);
width: auto;
padding: 0.5rem 0;

Expand Down