Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vectorize=True option to apply_ufunc #1615

Merged
merged 7 commits into from
Oct 27, 2017

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Oct 10, 2017

This provides an easier way to use apply_ufunc, for wrapping non-ufuncs that only act on core dimensions.

  • Tests added / passed
  • Passes git diff upstream/master | flake8 --diff

multiple outputs, you most set ``output_core_dims`` as well.
the style of NumPy universal functions [1]_ (if this is not the case,
set ``vectorize=True``). If this function returns multiple outputs, you
most set ``output_core_dims`` as well.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most -> must

@shoyer shoyer force-pushed the apply-ufunc-vectorize branch from 5f325ef to 9beeddf Compare October 21, 2017 00:57
first_samples, second_samples,
input_core_dims=[[dim], [dim]],
vectorize=True)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhamman any thoughts on this docstring update?

@shoyer shoyer mentioned this pull request Oct 27, 2017
13 tasks
@shoyer shoyer merged commit da7972c into pydata:master Oct 27, 2017
@shoyer shoyer deleted the apply-ufunc-vectorize branch October 27, 2017 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants