concat_dim for auto_combine for a single object is now respected #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WeatherGod
commented
Apr 10, 2018
WeatherGod
commented
- Closes open_mfdataset() on a single file drops the concat_dim #1988
- Tests added (for all bug fixes or enhancements)
- Tests passed (for all non-documentation changes)
stickler-ci
reviewed
Apr 10, 2018
xarray/tests/test_backends.py
Outdated
| @@ -2039,6 +2039,22 @@ def test_open_dataset(self): | |||
| self.assertIsInstance(actual.foo.variable.data, np.ndarray) | |||
| assert_identical(original, actual) | |||
|
|
|||
|
|
|||
| def test_open_single_dataset(self): | |||
There was a problem hiding this comment.
E303 too many blank lines (2)
xarray/tests/test_combine.py
Outdated
| 'y': (('baz', 'z'), [[1, 2]])}, | ||
| {'baz': [100]}) | ||
| assert_identical(expected, actual) | ||
|
|
There was a problem hiding this comment.
W391 blank line at end of file
WeatherGod
force-pushed
the
fix_single_combine
branch
from
52c8158 to
6057525
Compare
|
Travis failures seem to be unrelated? |
Yes, see #2050 |
|
Looks good to me. Could you kindly add a release note in what's new? |
|
What's new entry added. |
|
OK, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.