-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2885 broadcast like #3127
Conversation
…ay into feature/2891-expand-dims
Codecov Report
@@ Coverage Diff @@
## master #3127 +/- ##
==========================================
+ Coverage 95.98% 95.99% +0.01%
==========================================
Files 63 63
Lines 12777 12784 +7
==========================================
+ Hits 12264 12272 +8
+ Misses 513 512 -1 |
This was branched off of #3127 by mistake. If both are merged, no issue. |
Hi @DavidMertz -- @dcherian already started working on this over in #3086. But there's probably something useful that could be combined between these pull requests, maybe some of the docs or tests? |
I realized the overlap only after I made the PR. Their implementation of factoring out the shared code is better than my simple wrapper. But my documention and tests are better. What's the best way to merge the best? I'm happy to do it, but not sure if it should be a new branch and PR, or a revision of one of the existing ones. |
I think I'm going to merge the other PR, then you can fork off of master again and add your doc/test improvements? |
Great. Will do. |
OK, I just merged #3086 in master. I would suggest either merging |
whats-new.rst
for all changes andapi.rst
for new API