Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2885 broadcast like #3127

Closed

Conversation

DavidMertz
Copy link
Contributor

@DavidMertz DavidMertz commented Jul 14, 2019

@codecov
Copy link

codecov bot commented Jul 14, 2019

Codecov Report

Merging #3127 into master will increase coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #3127      +/-   ##
==========================================
+ Coverage   95.98%   95.99%   +0.01%     
==========================================
  Files          63       63              
  Lines       12777    12784       +7     
==========================================
+ Hits        12264    12272       +8     
+ Misses        513      512       -1

@DavidMertz
Copy link
Contributor Author

This was branched off of #3127 by mistake. If both are merged, no issue.

@shoyer
Copy link
Member

shoyer commented Jul 14, 2019

Hi @DavidMertz -- @dcherian already started working on this over in #3086. But there's probably something useful that could be combined between these pull requests, maybe some of the docs or tests?

@DavidMertz
Copy link
Contributor Author

I realized the overlap only after I made the PR. Their implementation of factoring out the shared code is better than my simple wrapper. But my documention and tests are better.

What's the best way to merge the best? I'm happy to do it, but not sure if it should be a new branch and PR, or a revision of one of the existing ones.

@shoyer
Copy link
Member

shoyer commented Jul 14, 2019

I think I'm going to merge the other PR, then you can fork off of master again and add your doc/test improvements?

@DavidMertz
Copy link
Contributor Author

Great. Will do.

@shoyer
Copy link
Member

shoyer commented Jul 14, 2019

OK, I just merged #3086 in master.

I would suggest either merging master into this PR branch, or (probably easier) making a new branch from master with your improved docs/tests.

@DavidMertz DavidMertz closed this Jul 14, 2019
@DavidMertz DavidMertz deleted the feature/2885-broadcast_like branch July 14, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add broadcast_like?
2 participants