fix test suite warnings re drop

[max-sixty]

Some more warnings silenced

[max-sixty]

ref #3266. This was causing about a quarter of the total, because of the test's parameterization.

[max-sixty]

One other issue: it suggests using drop_vars but that doesn't exist!

[shoyer]

One other issue: it suggests using drop_vars but that doesn't exist!

Yes, this was a suggestion for a new method

[max-sixty]

Yes, this was a suggestion for a new method

How would this work differently from .drop(var_name)? Or would we deprecate that use of drop?

[shoyer]

I think the idea is just to provide a more explicit option for dropping variables instead of labels. It's a little messy all in one API.

…

On Wed, Oct 30, 2019 at 6:30 PM Maximilian Roos ***@***.***> wrote: Yes, this was a suggestion for a new method How would this work differently from .drop(var_name)? Or would we deprecate that use of drop? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3460?email_source=notifications&email_token=AAJJFVQVAGWK6TUU6JPFZA3QRIYMDA5CNFSM4JGOGT52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECWI3QI#issuecomment-548179393>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJJFVT7WTBA7N5VOPPRNS3QRIYMDANCNFSM4JGOGT5Q> .

[max-sixty]

I think the idea is just to provide a more explicit option for dropping variables instead of labels. It's a little messy all in one API.

Yeah, agree it's messy. I think we could have drop_vars, completely deprecate any use of drop apart from lables, and then we're in a decent place? Or is that too much churn?

[shoyer]

Yeah, that was my thought

…

On Wed, Oct 30, 2019 at 6:43 PM Maximilian Roos ***@***.***> wrote: I think the idea is just to provide a more explicit option for dropping variables instead of labels. It's a little messy all in one API. Yeah, agree it's messy. I think we could have drop_vars, completely deprecate any use of drop apart from lables, and then we're in a decent place? Or is that too much churn? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3460?email_source=notifications&email_token=AAJJFVQCFMCNQTGOOZQ5VJTQRIZ5LA5CNFSM4JGOGT52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECWJOMA#issuecomment-548181808>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJJFVQTAUQ6ITQGU3AJ4UTQRIZ5LANCNFSM4JGOGT5Q> .