Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How do I add a new variable to dataset. #3679

Merged
merged 5 commits into from
Jan 10, 2020
Merged

How do I add a new variable to dataset. #3679

merged 5 commits into from
Jan 10, 2020

Conversation

rpgoldman
Copy link
Contributor

Closes #3678

I don't have the full build environment: someone who does will have to make sure that I got the sphinx formatting right.

dcherian
dcherian reviewed Jan 9, 2020
View reviewed changes
doc/howdoi.rst Outdated Show resolved Hide resolved
@rpgoldman
Copy link
Contributor Author

OK, I have tried to do as you suggested.

I looked at the directions for building the docs as you suggested, and I'm afraid it's too big an ask for me. I don't use conda, and I can't spare the time to learn it. Similarly, I know enough RST to write numpy-style docstrings, but I don't have the time to learn Sphinx. With all due respect, if xarray wants contributions from people like me, something has to be done to make this easier.

I'm just doing this because I'm contributing to Arviz, which depends on xarray. I can try to fix things if I see something wrong in the "Docs" check, but that's all I can do, I'm afraid.

@rpgoldman rpgoldman force-pushed the rpgoldman-how-do-i-add-new-variable branch from 6032383 to a830502 Compare January 10, 2020 17:14
@rpgoldman
Copy link
Contributor Author

I didn't get the cross-reference syntax right. I've tried to fix it, and am waiting for a new check.

@rpgoldman
Copy link
Contributor Author

OK, I'm not trying to be difficult, but I think someone else who knows how RST works could fix this in 2.4 seconds, or I could bang my head on it for hours.

Would someone please just fix my syntax error and merge this?

keewis
keewis reviewed Jan 10, 2020
View reviewed changes
doc/howdoi.rst Outdated Show resolved Hide resolved
@rpgoldman @keewis
Update doc/howdoi.rst
877352d 
Suggestion from keewis

Co-Authored-By: keewis <[email protected]>
@rpgoldman rpgoldman force-pushed the rpgoldman-how-do-i-add-new-variable branch from 974fd67 to 877352d Compare January 10, 2020 19:36
@dcherian
Copy link
Contributor

Great. Thanks @rpgoldman Welcome to xarray!

@dcherian dcherian merged commit ff75081 into pydata:master Jan 10, 2020
@rpgoldman rpgoldman deleted the rpgoldman-how-do-i-add-new-variable branch January 10, 2020 20:12
dcherian added a commit to dcherian/xarray that referenced this pull request Jan 14, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into groupby-plot
a834dde 
* upstream/master:
  allow passing any iterable to drop when dropping variables (pydata#3693)
  Typo on DataSet/DataArray.to_dict documentation (pydata#3692)
  Fix mypy type checking tests failure in ds.merge (pydata#3690)
  Explicitly convert result of pd.to_datetime to a timezone-naive type (pydata#3688)
  ds.merge(da) bugfix (pydata#3677)
  fix docstring for combine_first: returns a Dataset (pydata#3683)
  Add option to choose mfdataset attributes source. (pydata#3498)
  How do I add a new variable to dataset. (pydata#3679)
  Add map_blocks example to whats-new (pydata#3682)
  Make dask names change when chunking Variables by different amounts. (pydata#3584)
  raise an error when renaming dimensions to existing names (pydata#3645)
  Support swap_dims to dimension names that are not existing variables (pydata#3636)
  Add map_blocks example to docs. (pydata#3667)
  add multiindex level name checking to .rename() (pydata#3658)
dcherian added a commit to dcherian/xarray that referenced this pull request Jan 15, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into ufunc-vectorize-meta
e8fabc4 
* upstream/master:
  Add an example notebook using apply_ufunc to vectorize 1D functions (pydata#3629)
  Use encoding['dtype'] over data.dtype when possible within CFMaskCoder.encode (pydata#3652)
  allow passing any iterable to drop when dropping variables (pydata#3693)
  Typo on DataSet/DataArray.to_dict documentation (pydata#3692)
  Fix mypy type checking tests failure in ds.merge (pydata#3690)
  Explicitly convert result of pd.to_datetime to a timezone-naive type (pydata#3688)
  ds.merge(da) bugfix (pydata#3677)
  fix docstring for combine_first: returns a Dataset (pydata#3683)
  Add option to choose mfdataset attributes source. (pydata#3498)
  How do I add a new variable to dataset. (pydata#3679)
  Add map_blocks example to whats-new (pydata#3682)
  Make dask names change when chunking Variables by different amounts. (pydata#3584)
  raise an error when renaming dimensions to existing names (pydata#3645)
  Support swap_dims to dimension names that are not existing variables (pydata#3636)
  Add map_blocks example to docs. (pydata#3667)
  add multiindex level name checking to .rename() (pydata#3658)
dcherian added a commit to dcherian/xarray that referenced this pull request Jan 21, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into optimize-lazy-equiv
6b20a3e 
* upstream/master: (23 commits)
  Feature/align in dot (pydata#3699)
  ENH: enable `H5NetCDFStore` to work with already open h5netcdf.File a… (pydata#3618)
  One-off isort run (pydata#3705)
  hardcoded xarray.__all__ (pydata#3703)
  Bump mypy to v0.761 (pydata#3704)
  remove DataArray and Dataset constructor deprecations for 0.15  (pydata#3560)
  Tests for variables with units (pydata#3654)
  Add an example notebook using apply_ufunc to vectorize 1D functions (pydata#3629)
  Use encoding['dtype'] over data.dtype when possible within CFMaskCoder.encode (pydata#3652)
  allow passing any iterable to drop when dropping variables (pydata#3693)
  Typo on DataSet/DataArray.to_dict documentation (pydata#3692)
  Fix mypy type checking tests failure in ds.merge (pydata#3690)
  Explicitly convert result of pd.to_datetime to a timezone-naive type (pydata#3688)
  ds.merge(da) bugfix (pydata#3677)
  fix docstring for combine_first: returns a Dataset (pydata#3683)
  Add option to choose mfdataset attributes source. (pydata#3498)
  How do I add a new variable to dataset. (pydata#3679)
  Add map_blocks example to whats-new (pydata#3682)
  Make dask names change when chunking Variables by different amounts. (pydata#3584)
  raise an error when renaming dimensions to existing names (pydata#3645)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis left review comments

@dcherian dcherian dcherian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: How Do I add a new variable to a data set?
3 participants
@rpgoldman @dcherian @keewis