Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for h5py deepcopy issues #4426

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Fix for h5py deepcopy issues #4426

merged 4 commits into from
Sep 18, 2020

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Sep 16, 2020 •
edited by dcherian
Loading

@pep8speaks
Copy link

pep8speaks commented Sep 16, 2020 •
edited
Loading

Hello @shoyer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-18 20:59:40 UTC

@shoyer shoyer mentioned this pull request Sep 16, 2020
Closed
@kmuehlbauer
Copy link
Contributor

@shoyer Thanks! I tested with the examples in #4425 and it fixes those issues. Would be great, if this could be merged before next release.

@kmuehlbauer
Copy link
Contributor

Any chance to get this into 0.16.1? Otherwise the new release might break existing code relying on behaviour before #4221. Thanks for considering.

@dcherian
Copy link
Contributor

Thanks for raising this @kmuehlbauer

Otherwise the new release might break existing code relying on behaviour before #4221.

@shoyer is this an OK temporary fix?

@shoyer
Copy link
Member Author

shoyer commented Sep 18, 2020

Coincidentally I just pushed a regression test.

Assuming CI passes, this should be good to go.

@dcherian dcherian changed the title WIP: Potential fix for h5py deepcopy issues Fix for h5py deepcopy issues Sep 18, 2020
@dcherian dcherian merged commit 2ed6d57 into pydata:master Sep 18, 2020
@dcherian
Copy link
Contributor

Thanks @shoyer

@max-sixty max-sixty mentioned this pull request Sep 22, 2020
Closed
dcherian added a commit to dcherian/xarray that referenced this pull request Oct 9, 2020
@dcherian
Merge branch 'propagate-attrs' of github.com:dcherian/xarray into pro…
1f998f0 
…pagate-attrs

* 'propagate-attrs' of github.com:dcherian/xarray: (22 commits)
  silence sphinx warnings about broken rst (pydata#4448)
  Xarray open_mfdataset with engine Zarr (pydata#4187)
  Fix release notes formatting (pydata#4443)
  fix typo in io.rst (pydata#4250)
  Fix typo (pydata#4181)
  Fix release notes typo
  New whatsnew section
  Add notes re doctests (pydata#4440)
  Fixed dask.optimize on datasets (pydata#4438)
  Release notes for 0.16.1 (pydata#4435)
  Small updates to How-to-release + lint (pydata#4436)
  Fix doctests (pydata#4439)
  add a ci for doctests (pydata#4437)
  preserve original dimension, coordinate and variable order in ``concat`` (pydata#4419)
  Fix for h5py deepcopy issues (pydata#4426)
  Keep the original ordering of the coordinates (pydata#4409)
  Clearer Vectorized Indexing example (pydata#4433)
  Revert "Fix optimize for chunked DataArray (pydata#4432)" (pydata#4434)
  Fix optimize for chunked DataArray (pydata#4432)
  fix doc dataarray to netcdf (pydata#4424)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deepcopying variable raises TypeError: h5py objects cannot be pickled (Dataset.sortby)
4 participants
@shoyer @pep8speaks @kmuehlbauer @dcherian