Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use condas dask-core in ci instead of dask to speedup ci and reduce dependencies #6007

Merged
merged 11 commits into from
Nov 28, 2021
Merged

Use condas dask-core in ci instead of dask to speedup ci and reduce dependencies #6007

merged 11 commits into from
Nov 28, 2021

Conversation

aaronspring
Copy link
Contributor

@aaronspring aaronspring commented Nov 19, 2021

  • Closes #xxxx
  • Tests added
  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

Tried to reduce dependencies from installing dask via conda which installs like pip install dask[complete]. dask-core is like pip install dask. xgcm/xhistogram#71 (comment)

Why? dask[complete] includes bokeh etc which are not needed here and likely speed up CI setup/install times

but now dask and dask-core are conda installed :( seems like iris installs dask https://github.com/conda-forge/iris-feedstock/blob/master/recipe/meta.yaml, so this would require an iris-feedstock PR first

linking SciTools/iris#4434 and conda-forge/iris-feedstock#77

@aaronspring aaronspring marked this pull request as draft November 20, 2021 23:27
@aaronspring aaronspring changed the title dask-core Use condas dask-core in ci instead of dask to speedup ci and reduce dependencies Nov 23, 2021
@aaronspring aaronspring marked this pull request as ready for review November 23, 2021 23:59
@aaronspring
Copy link
Contributor Author

bokeh etc not installed anymore when temporarily not installing iris from conda https://github.com/pydata/xarray/runs/4298565586?check_suite_focus=true

ci/requirements/doc.yml Outdated Show resolved Hide resolved
@dcherian dcherian added the plan to merge Final call for comments label Nov 24, 2021
@dcherian dcherian merged commit cc03589 into pydata:main Nov 28, 2021
@aaronspring aaronspring deleted the patch-1 branch November 28, 2021 21:01
dcherian added a commit to dcherian/xarray that referenced this pull request Dec 2, 2021
* upstream/main:
  fix grammatical typo in docs (pydata#6034)
  Use condas dask-core in ci instead of dask to speedup ci and reduce dependencies (pydata#6007)
  Use complex nan by default when interpolating out of bounds (pydata#6019)
  Simplify missing value handling in xarray.corr (pydata#6025)
  Add pyXpcm to Related Projects doc page (pydata#6031)
  Make xr.corr and xr.map_blocks work without dask (pydata#5731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants