Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install numbagg from conda-forge #7415

Merged
merged 5 commits into from
Jan 20, 2023

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jan 4, 2023

It seems there is a numbagg package on conda-forge now.

Not sure what to do about the min-all-deps CI, but given that the most recent version of numbagg happened more than 12 months ago (more than 18 months, even) maybe we can just bump it to the version on conda-forge?

@github-actions github-actions bot added CI Continuous Integration tools dependencies Pull requests that update a dependency file labels Jan 4, 2023
@keewis
Copy link
Collaborator Author

keewis commented Jan 4, 2023

that looks like it works, besides the fact that conda reports numbagg=0.2.1 but

print(f"numbagg={numbagg.__version__}")

prints numbagg=0.2.0 (cc @ocefpaf)

@ocefpaf
Copy link
Contributor

ocefpaf commented Jan 4, 2023

that looks like it works, besides the fact that conda reports numbagg=0.2.1 but

It is not a conda problem but a bug upstream. The v0.2.1 tag hasv0.2.0 hardcoded in it.

See https://github.com/numbagg/numbagg/blob/v0.2.1/setup.py#L24

@keewis
Copy link
Collaborator Author

keewis commented Jan 4, 2023

ah, that makes sense, thanks. I must have missed that line while checking the package metadata. This has even been fixed since then, but not released. @max-sixty, would it be possible to issue a new release?

@max-sixty
Copy link
Collaborator

This has even been fixed since then, but not released. @max-sixty, would it be possible to issue a new release?

This should now be releasing! https://github.com/numbagg/numbagg/releases/tag/v0.2.2

@keewis
Copy link
Collaborator Author

keewis commented Jan 16, 2023

do we need to worry about this:

Traceback (most recent call last):
  File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/doctest.py", line 1350, in __run
    exec(compile(example.source, filename, "single",
  File "<doctest xarray.core.rolling_exp.RollingExp.sum[1]>", line 1, in <module>
  File "/home/runner/work/xarray/xarray/xarray/core/rolling_exp.py", line 162, in sum
    return self.obj.reduce(
  File "/home/runner/work/xarray/xarray/xarray/core/dataarray.py", line 3667, in reduce
    var = self.variable.reduce(func, dim, axis, keep_attrs, keepdims, **kwargs)
  File "/home/runner/work/xarray/xarray/xarray/core/variable.py", line 1955, in reduce
    data = func(self.data, axis=axis, **kwargs)
  File "/home/runner/work/xarray/xarray/xarray/core/rolling_exp.py", line 41, in move_exp_nansum
    raise ValueError("`rolling_exp(...).sum() requires numbagg>=0.2.1.")
ValueError: `rolling_exp(...).sum() requires numbagg>=0.2.1.

not being caught by CI?

Edit: to answer my own question: no, because most of the the rolling_exp tests are explicitly skipped if the numbagg version is too old

@keewis keewis merged commit 19838dc into pydata:main Jan 20, 2023
@keewis keewis deleted the install-numbagg-from-conda-forge branch January 20, 2023 19:46
dcherian added a commit to dcherian/xarray that referenced this pull request Jan 25, 2023
* upstream/main:
  RTD maintenance (pydata#7477)
  fix the RTD build skipping feature (pydata#7476)
  Add benchmarks for to_dataframe and to_dask_dataframe (pydata#7474)
  allow skipping RTD builds (pydata#7470)
  create separate environment files for `python=3.11` (pydata#7469)
  Bump mamba-org/provision-with-micromamba from 14 to 15 (pydata#7466)
  install `numbagg` from `conda-forge` (pydata#7415)
  Fill missing data_vars during concat by reindexing (pydata#7400)
  [skip-cii] Add pyodide update instructions to HOW_TO_RELEASE (pydata#7449)
  [skip-ci] whats-new for next release (pydata#7455)
  v2023.01.0 whats-new (pydata#7440)
@keewis keewis mentioned this pull request Aug 10, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tools dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants