Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_doc_example on big-endian systems #9949

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Fix test_doc_example on big-endian systems #9949

merged 1 commit into from
Jan 23, 2025

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Jan 14, 2025

... by using a fixed-endian input.

  • [n/a] Closes #xxxx
  • Tests added
  • [n/a] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [n/a] New functions/methods are listed in api.rst

@max-sixty
Copy link
Collaborator

Tried to merge main to see if that fixed the failures...

@max-sixty
Copy link
Collaborator

I think the test failures are unrelated — do you agree @QuLogic ?

@QuLogic
Fix test_doc_example on big-endian systems
34fa7e7 
... by using a fixed-endian input.
@QuLogic
Copy link
Contributor Author

QuLogic commented Jan 23, 2025

I'd certainly say so, but I rebased anyway.

@max-sixty max-sixty merged commit 10b68c3 into pydata:main Jan 23, 2025
28 of 29 checks passed
@QuLogic QuLogic deleted the s390x-test branch January 23, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuLogic @max-sixty