Remove pip import and version check from setup.py to make doit install with setuptools 50.0 #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to how setuptools 50 works means that installing doit crashes with a cryptic KeyError (most likely caused by setuptools and pip’s monkeypatching of distutils). This check is not really necessary (most people have a newer pip these days).
This was referenced Aug 31, 2020
Closed
|
thanks. also added a wheel file as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to how setuptools 50 works means that installing doit crashes with a cryptic KeyError (most likely caused by setuptools and pip’s monkeypatching of distutils). This check is not really necessary (most people have a newer pip these days).
Error:
$ ./setup.py /tmp/venv/lib64/python3.8/site-packages/_distutils_hack/__init__.py:30: UserWarning: Setuptools is replacing distutils. warnings.warn("Setuptools is replacing distutils.") Traceback (most recent call last): File "./setup.py", line 44, in <module> setup(name = 'doit', File "/tmp/venv/lib64/python3.8/site-packages/setuptools/__init__.py", line 152, in setup _install_setup_requires(attrs) File "/tmp/venv/lib64/python3.8/site-packages/setuptools/__init__.py", line 145, in _install_setup_requires dist.parse_config_files(ignore_option_errors=True) File "/tmp/venv/lib64/python3.8/site-packages/setuptools/dist.py", line 665, in parse_config_files self._parse_config_files(filenames=filenames) File "/tmp/venv/lib64/python3.8/site-packages/setuptools/dist.py", line 572, in _parse_config_files filenames = self.find_config_files() File "/tmp/venv/lib64/python3.8/site-packages/setuptools/_distutils/dist.py", line 353, in find_config_files sys_dir = os.path.dirname(sys.modules['distutils'].__file__) KeyError: 'distutils'Please consider making a new release to PyPI, since this makes it hard to install doit (and its dependents, like Nikola). Please also consider adding wheels to the PyPI release to simplify installation (
./setup.py sdist bdist_wheelto build, then upload both files).