Add support to unicode file name #22
Conversation
|
Your PR is welcome. Would you like to go an extra mile, to include a test case for your change as well? |
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 98.54% 98.67% +0.13%
==========================================
Files 7 7
Lines 274 302 +28
==========================================
+ Hits 270 298 +28
Misses 4 4
Continue to review full report at Codecov.
|
|
I have updated test case and add a demo to |
examples/tiny_example.py
Outdated
| @@ -34,6 +35,18 @@ def export_records(): | |||
| file_name="export_data") | |||
|
|
|||
|
|
|||
| @app.route("/download_unicode_file_name_utf8", methods=['GET']) | |||
There was a problem hiding this comment.
I see that you would like to show both str and unicode are handled with your change. However, I would suggest let's keep one of the two demo functions.
| @@ -71,8 +76,11 @@ def test_no_file_type(self): | |||
| def test_override_file_name(self): | |||
| for file_type in FILE_TYPE_MIME_TABLE.keys(): | |||
| file_name = 'override_file_name' | |||
| url_encoded_file_name = quote(file_name) | |||
There was a problem hiding this comment.
As you have tried to demonstrate in the tiny_example.py, could you please invest a bit more effort in writing two additional test case for the previous two demo functions.
|
It looks good so far. Please see my comments. In terms of release, I think I will quickly get it out of the door if all required is done. |
|
WOW! Thank you! If there are something need improved, please let me know. |
|
It will be released under New BSD license and your change will be migrated to its siblings: django-excel and pyramid-excel. Are you happy with what will happen next? |
…opyright so that at least contributor had a share of the copyright under new bsd.
|
It's a pleasure to see my code can serve so many great projects. I am very happy with that. |
|
That's what I'd like to hear. Thanks. The release will follow. |
|
published. |
No description provided.