Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨 Edit for forward compatibility #74

Merged
merged 2 commits into from
Nov 11, 2024
Merged

🚨 Edit for forward compatibility #74

merged 2 commits into from
Nov 11, 2024

Conversation

yeop-sang
Copy link
Contributor

@yeop-sang yeop-sang commented Aug 18, 2022 •
edited
Loading

Edit urls.py files for forward compatibility and Change xlrd version for pyexcel-xls.

This commit is fixing the issue #73.

With your PR, here is a check list:

  • Has test cases written? - Don't need Just change some codes
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

@yeop-sang yeop-sang marked this pull request as draft August 23, 2022 05:27
@yeop-sang yeop-sang marked this pull request as ready for review August 23, 2022 05:27
@chfw chfw merged commit 1ddf73c into pyexcel-webwares:master Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeop-sang @chfw