Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support edge features in GATConv #3078

Merged
merged 12 commits into from
Oct 12, 2021
Merged

Support edge features in GATConv #3078

merged 12 commits into from
Oct 12, 2021

Conversation

dongkwan-kim
Copy link
Contributor

Related to #810

Some design choices that I made:

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2021

Codecov Report

Merging #3078 (7444821) into master (fdc7d5a) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3078      +/-   ##
==========================================
+ Coverage   72.84%   72.91%   +0.06%     
==========================================
  Files         282      282              
  Lines       13629    13662      +33     
==========================================
+ Hits         9928     9961      +33     
  Misses       3701     3701              
Impacted Files Coverage Δ
torch_geometric/nn/conv/gat_conv.py 100.00% <100.00%> (ø)
torch_geometric/utils/loop.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc7d5a...7444821. Read the comment docs.

@rusty1s
Copy link
Member

rusty1s commented Oct 12, 2021

Finally had some time to look into this. This is great, thank you!

@rusty1s rusty1s merged commit 177d928 into pyg-team:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants