Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output metadata processing in loaders 'filter_fn()` for multinode #8377

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

JakubPietrakIntel
Copy link
Contributor

@JakubPietrakIntel JakubPietrakIntel commented Nov 14, 2023

The output of DistributedNeighborSampler._collate_fn() includes nfeats, nlabels, efeats which are our metadata[-3], metadata[-2] and metadata[-1]. Here: L717C1-L718C22

@JakubPietrakIntel JakubPietrakIntel changed the title Fix output metadata processing in loader's 'filter_fn()` Fix output metadata processing in loaders 'filter_fn()` for multinode Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (ccbbbdd) 88.42% compared to head (f32b554) 88.39%.
Report is 2 commits behind head on master.

❗ Current head f32b554 differs from pull request most recent head d1b901b. Consider uploading reports for the commit d1b901b to get more accurate results

Files Patch % Lines
torch_geometric/loader/link_loader.py 0.00% 5 Missing ⚠️
torch_geometric/loader/node_loader.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8377      +/-   ##
==========================================
- Coverage   88.42%   88.39%   -0.03%     
==========================================
  Files         475      475              
  Lines       28839    28843       +4     
==========================================
- Hits        25500    25496       -4     
- Misses       3339     3347       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +231 to +233
# TODO Integrate features.

# Hack to detect whether we are in a distributed setting.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I misunderstood the implementation, sorry :)

From a PyG interface perspective, I personally think it is quite confusing that SamplerOutput also returns the features, but I see that it makes sense to fetch the features during sampling. However, this does not really seem to generalize to more feature attributes (e.g., time), so let me know if there exists plans to extend this to more general cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries :) thanks for correcting that quickly. You're right, we will need revise our Sampler output to be more customizable. Remark noted!

@rusty1s rusty1s enabled auto-merge (squash) November 14, 2023 19:06
@rusty1s rusty1s merged commit 31b386b into master Nov 14, 2023
@rusty1s rusty1s deleted the intel/loaders_filter_fix branch November 14, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants