-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix output metadata processing in loaders 'filter_fn()` for multinode #8377
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8377 +/- ##
==========================================
- Coverage 88.42% 88.39% -0.03%
==========================================
Files 475 475
Lines 28839 28843 +4
==========================================
- Hits 25500 25496 -4
- Misses 3339 3347 +8 ☔ View full report in Codecov by Sentry. |
# TODO Integrate features. | ||
|
||
# Hack to detect whether we are in a distributed setting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I misunderstood the implementation, sorry :)
From a PyG interface perspective, I personally think it is quite confusing that SamplerOutput
also returns the features, but I see that it makes sense to fetch the features during sampling. However, this does not really seem to generalize to more feature attributes (e.g., time
), so let me know if there exists plans to extend this to more general cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries :) thanks for correcting that quickly. You're right, we will need revise our Sampler output to be more customizable. Remark noted!
The output of
DistributedNeighborSampler._collate_fn()
includesnfeats, nlabels, efeats
which are ourmetadata[-3]
,metadata[-2]
andmetadata[-1]
. Here: L717C1-L718C22