Fix GlobalStorage.is_node_attr and GlobalStorage.is_edge_attr when passing tuples in cat_dim
#9927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erytheis
changed the title
… for sparse attributes with tuple as __cat_dim__
erytheis
force-pushed
the
fix_is_node_attr_for_sparse
branch
from
596ecd9 to
7b714b2
Compare
|
I would assume that if |
rusty1s
changed the title
GlobalStorage.is_node_attr and GlobalStorage.is_edge_attr when passing tuples in cat_dim
rusty1s
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes the issue when calling is_node_attr and is_edge_attr for Data objects with sparse attributes that assume block-diagonal concatenation ( #9895 and in #8709). These cases raise an error due to cat_dim being a tuple, the change catches this case and looks at the 0-th dimension of the sparse tensor.