Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for a deprecation in metric.py #312

Closed
eric-wieser opened this issue May 6, 2020 · 0 comments · Fixed by #398
Closed

Add test for a deprecation in metric.py #312

eric-wieser opened this issue May 6, 2020 · 0 comments · Fixed by #398
Labels
Deprecation Precursor to removal of features
Milestone
0.5.0

Comments

@eric-wieser
Copy link
Member

eric-wieser commented May 6, 2020 •
edited
Loading

galgebra/galgebra/metric.py

Lines 422 to 426 in 8aff51f

def derivatives_of_g(self):
# galgebra 0.5.0
warnings.warn(
"Metric.derivatives_of_g is deprecated, and now does nothing. "
"the `.dg` property is now always available.")

I forgot to add a test for this in #310. The warning type and stacklevel are also missing.
@eric-wieser eric-wieser added the Deprecation Precursor to removal of features label May 6, 2020
@eric-wieser eric-wieser added this to the 0.5.0 milestone May 6, 2020
eric-wieser added a commit to eric-wieser/galgebra that referenced this issue May 26, 2020
@eric-wieser
Add missing tests for deprecations
d06a5a1 
Fixes pygae#312, and also updates the changelog with information about the changes that led to this deprecation.
eric-wieser added a commit to eric-wieser/galgebra that referenced this issue May 26, 2020
@eric-wieser
Add missing tests for deprecations
13ac1ad 
Fixes pygae#312, and also updates the changelog with information about the changes that led to this deprecation.
@eric-wieser eric-wieser mentioned this issue May 26, 2020
Merged
eric-wieser added a commit to eric-wieser/galgebra that referenced this issue May 26, 2020
@eric-wieser
Add missing tests for deprecations
9ecd033 
Fixes pygae#312, and also updates the changelog with information about the changes that led to this deprecation.
utensil pushed a commit that referenced this issue May 26, 2020
@eric-wieser
Add missing tests for deprecations (#398)
2c8f1eb 
Fixes #312, and also updates the changelog with information about the changes that led to this deprecation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecation Precursor to removal of features
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Add missing tests for deprecations eric-wieser/galgebra
1 participant
@eric-wieser