-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves #99 add support for JRuby #162
Conversation
Please note of the following facts:
|
286fadf
to
6c7ff87
Compare
I recognize that Rouge is now the preferred gem over pygments.rb. However, there are still integrations which rely on this gem that haven't had a chance to make the switch. Support for JRuby would really help in this transition period. |
6c7ff87
to
216bcb0
Compare
When RUBY_ENGINE == 'jruby', do the following: - map popen4 function to Open.popen3 - map Yajl to MultiJson and set MultiJson engine to json_gem - update gemspec to build -java gem when running under JRuby - drop posix/spawn and yaml dependencies and add multi_json Additionally, add rake and test-unit as development dependencies so rake and tests can be run via Bundler, respectively.
216bcb0
to
d0259bc
Compare
This gem depends on the very POSIX process model. If you want to execute pygments for JRuby, it should be better that you call Or, consider https://github.com/jneen/rouge, which is written in pure Ruby. |
Seriously?!? Come on. This fix is critical for compatibility across Ruby platforms (esp during the transition to Rouge, which can't happen overnight). I spent a lot of time to figure this solution out and I think it is very reasonable. Can you please respect that effort and not close the door on JRuby? I urge you to reconsider. |
Hmm, okay, will try to get compatibility with JRuby and keep it as much as possible. However, dynamic dependencies in gemspec are useless. Can you fix some points?
|
Thank you. I'd be glad to update the patch. Stay tuned. |
The idea of this PR is included in #170. Thanks to the suggestion. |
When RUBY_ENGINE == 'jruby', do the following:
Additionally, add rake and test-unit as development dependencies so rake and tests can be run via Bundler, respectively.