Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] use ImportAlarm from pyiron_snippets #1431

Merged
merged 3 commits into from
Jun 3, 2024
Merged

[patch] use ImportAlarm from pyiron_snippets #1431

merged 3 commits into from
Jun 3, 2024

Conversation

liamhuber
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented May 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9322255498

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 71.043%
Totals Coverage Status
Change from base Build 9252553662: 0.01%
Covered Lines: 10638
Relevant Lines: 14974
💛 - Coveralls

@liamhuber liamhuber marked this pull request as ready for review May 31, 2024 17:50
@liamhuber liamhuber requested a review from pmrv May 31, 2024 17:50
This was referenced May 31, 2024
Merged
Closed
@liamhuber liamhuber mentioned this pull request Jun 3, 2024
Merged
jan-janssen
jan-janssen approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jan-janssen jan-janssen merged commit 454b1e9 into main Jun 3, 2024
25 checks passed
@jan-janssen jan-janssen deleted the snippets_alarm branch June 3, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

@pmrv pmrv Awaiting requested review from pmrv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liamhuber @coveralls @jan-janssen