Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main #1555

Merged
merged 60 commits into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
be5ede2
Bump pyiron-base from 0.9.12 to 0.10.0
dependabot[bot] Aug 20, 2024
b62c82b
Update environment.yml
jan-janssen Aug 20, 2024
9e1db77
Update environment-docs.yml
jan-janssen Aug 20, 2024
c80d718
Update environment.yml
jan-janssen Aug 20, 2024
392d953
Rename dictionary objects to obj_dict
jan-janssen Aug 20, 2024
77b0940
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 20, 2024
e88cc58
Give it a try with a new file name
samwaseda Aug 20, 2024
85c7c59
again, add extension
samwaseda Aug 20, 2024
1ed73e7
correct path
samwaseda Aug 20, 2024
880df96
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 20, 2024
3cf8cd2
Update environment-old.yml
jan-janssen Aug 22, 2024
29ce793
Update unittests_old.yml
jan-janssen Aug 22, 2024
4f2dabf
Bump structuretoolkit from 0.0.27 to 0.0.28
dependabot[bot] Aug 23, 2024
445d23a
[dependabot skip] Update environment
github-actions[bot] Aug 23, 2024
3405dab
Pass axis in QHA job plotting
pmrv Aug 23, 2024
7f09393
Merge pull request #1534 from pyiron/dependabot/pip/structuretoolkit-…
jan-janssen Aug 24, 2024
f4f8b22
Bump scipy from 1.14.0 to 1.14.1
dependabot[bot] Aug 24, 2024
50aed01
[dependabot skip] Update environment
github-actions[bot] Aug 24, 2024
92c9dd4
Update environment-docs.yml
jan-janssen Aug 24, 2024
8d9e2d9
Update environment.yml
jan-janssen Aug 24, 2024
d8f44af
Update environment.yml
jan-janssen Aug 24, 2024
27626f8
Update pyproject.toml
jan-janssen Aug 24, 2024
03d6153
Merge pull request #1533 from pyiron/dependabot/pip/scipy-1.14.1
jan-janssen Aug 24, 2024
e906a41
Merge pull request #1531 from pyiron/dependabot/pip/pyiron-base-0.10.0
jan-janssen Aug 24, 2024
37726b5
Bump pylammpsmpi from 0.2.23 to 0.2.24
dependabot[bot] Aug 26, 2024
6730ccb
[dependabot skip] Update environment
github-actions[bot] Aug 26, 2024
a76cfb5
Merge pull request #1540 from pyiron/dependabot/pip/pylammpsmpi-0.2.24
jan-janssen Aug 26, 2024
b2e91c4
VASP: Add collect_output() function again
jan-janssen Aug 26, 2024
cf8927d
Emit warning when trying to set negative number of empty bands in DFT…
pmrv Aug 26, 2024
0a4cb80
Merge pull request #1543 from pyiron/cbar
pmrv Aug 26, 2024
e1885c4
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Aug 26, 2024
ba21078
Merge pull request #1546 from pyiron/pre-commit-ci-update-config
jan-janssen Aug 27, 2024
ddde196
Remove conda default channel
jan-janssen Aug 27, 2024
6b2db53
update to v3
jan-janssen Aug 27, 2024
2ebf9f1
Bump pylammpsmpi from 0.2.24 to 0.2.25
dependabot[bot] Aug 27, 2024
b5a0ed5
[dependabot skip] Update environment
github-actions[bot] Aug 27, 2024
e75529c
Update benchmarks.yml
jan-janssen Aug 27, 2024
f1abd8d
Merge pull request #1548 from pyiron/dependabot/pip/pylammpsmpi-0.2.25
jan-janssen Aug 27, 2024
6296410
Merge pull request #1541 from pyiron/vasp_collect_output
jan-janssen Aug 27, 2024
a9a3da6
Merge pull request #1547 from pyiron/nodev
jan-janssen Aug 27, 2024
2110301
clears output for restarted jobs
skatnagallu Aug 28, 2024
f7309df
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 28, 2024
02b2842
output init calls the clear_output_for_restart
skatnagallu Aug 28, 2024
0c8da16
Update pyiron_atomistics/sphinx/base.py
skatnagallu Aug 28, 2024
46186d1
Update pyiron_atomistics/sphinx/base.py
skatnagallu Aug 28, 2024
4f35bdc
Update pyiron_atomistics/sphinx/base.py
skatnagallu Aug 28, 2024
ffc1aef
changed the function name to clear
skatnagallu Aug 28, 2024
9ee71e7
Update comment to reflect changed method name
pmrv Aug 28, 2024
b8cb774
Merge pull request #1549 from pyiron/clear_output_sphinx
pmrv Aug 28, 2024
3451dd1
Restore ValueError
pmrv Aug 29, 2024
6772bfc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 29, 2024
f19f747
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Sep 2, 2024
e9c25ca
Merge pull request #1550 from pyiron/pre-commit-ci-update-config
jan-janssen Sep 2, 2024
936d9f9
Update pyproject.toml
jan-janssen Sep 6, 2024
130116f
Update environment.yml
jan-janssen Sep 6, 2024
1f7fc27
Update environment-docs.yml
jan-janssen Sep 6, 2024
0759f69
Update environment.yml
jan-janssen Sep 6, 2024
0fe01f9
Merge pull request #1554 from pyiron/pyiron_base
jan-janssen Sep 6, 2024
dd98e78
Allow zero empty states
pmrv Sep 6, 2024
8fa6b31
Merge pull request #1542 from pyiron/bands
pmrv Sep 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .ci_support/environment-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dependencies:
- myst-parser
- aimsgb =1.1.0
- ase =3.23.0
- atomistics =0.1.31
- atomistics =0.1.32
- defusedxml =0.7.1
- h5py =3.11.0
- matplotlib-base =3.9.2
Expand All @@ -17,14 +17,14 @@ dependencies:
- pandas =2.2.2
- phonopy =2.26.6
- pint =0.24.3
- pyiron_base =0.9.12
- pyiron_base =0.10.1
- pyiron_snippets =0.1.4
- pylammpsmpi =0.2.23
- pylammpsmpi =0.2.25
- pyscal3 =3.2.7
- scikit-learn =1.5.1
- scipy =1.14.0
- scipy =1.14.1
- seekpath =2.1.0
- spglib =2.5.0
- structuretoolkit =0.0.27
- structuretoolkit =0.0.28
- pyxtal =0.6.2
- jupyter-book =1.0.0
2 changes: 1 addition & 1 deletion .ci_support/environment-old.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dependencies:
- pandas =2.0.3
- phonopy =2.20.0
- pint =0.18
- pyiron_base =0.9.12
- pyiron_base =0.10.0
- pyiron_snippets =0.1.3
- pylammpsmpi =0.2.18
- pyscal3 =3.2.5
Expand Down
10 changes: 5 additions & 5 deletions .ci_support/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ channels:
dependencies:
- aimsgb =1.1.0
- ase =3.23.0
- atomistics =0.1.31
- atomistics =0.1.32
- coverage
- codacy-coverage
- defusedxml =0.7.1
Expand All @@ -15,13 +15,13 @@ dependencies:
- pandas =2.2.2
- phonopy =2.26.6
- pint =0.24.3
- pyiron_base =0.9.12
- pyiron_base =0.10.1
- pyiron_snippets =0.1.4
- pylammpsmpi =0.2.23
- pylammpsmpi =0.2.25
- pyscal3 =3.2.7
- scikit-learn =1.5.1
- scipy =1.14.0
- scipy =1.14.1
- seekpath =2.1.0
- spglib =2.5.0
- structuretoolkit =0.0.27
- structuretoolkit =0.0.28
- pyxtal =0.6.2
10 changes: 4 additions & 6 deletions .github/workflows/backwards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,14 @@ jobs:
run: |
cp .ci_support/environment.yml environment.yml
tail --lines=+4 .ci_support/environment-notebooks.yml >> environment.yml
echo -e "channels:\n - conda-forge\n" > .condarc
- name: Setup Mambaforge
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
python-version: '3.10'
miniforge-variant: Mambaforge
channels: conda-forge
channel-priority: strict
activate-environment: my-env
miniforge-version: latest
condarc-file: .condarc
environment-file: environment.yml
use-mamba: true
- name: Test
shell: bash -l {0}
run: |
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,16 @@ jobs:

steps:
- uses: actions/checkout@v4
- name: Conda config
shell: bash -l {0}
run: echo -e "channels:\n - conda-forge\n" > .condarc
- name: Setup Mambaforge
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
python-version: ${{ matrix.python-version }}
miniforge-variant: Mambaforge
channels: conda-forge
channel-priority: strict
activate-environment: my-env
miniforge-version: latest
condarc-file: .condarc
environment-file: .ci_support/environment.yml
use-mamba: true
- name: Tests
shell: bash -l {0}
timeout-minutes: 30
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,13 @@ jobs:
id-token: write
steps:
- uses: actions/checkout@v4
- uses: conda-incubator/[email protected]
- name: Conda config
run: echo -e "channels:\n - conda-forge\n" > .condarc
- uses: conda-incubator/setup-miniconda@v3
with:
python-version: "3.12"
mamba-version: "*"
channels: conda-forge
miniforge-variant: Mambaforge
channel-priority: strict
auto-update-conda: true
miniforge-version: latest
condarc-file: .condarc
environment-file: .ci_support/environment.yml
- name: Convert dependencies
run: |
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,14 @@ jobs:
run: |
cp .ci_support/environment.yml environment.yml
tail --lines=+4 .ci_support/environment-notebooks.yml >> environment.yml
echo -e "channels:\n - conda-forge\n" > .condarc
- name: Setup Mambaforge
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
python-version: '3.12'
miniforge-variant: Mambaforge
channels: conda-forge
channel-priority: strict
activate-environment: my-env
miniforge-version: latest
condarc-file: .condarc
environment-file: environment.yml
use-mamba: true
- name: Test
shell: bash -l {0}
run: |
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/integration_unittests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,14 @@ jobs:
run: |
cp .ci_support/environment.yml environment.yml
tail --lines=+4 .ci_support/environment-notebooks.yml >> environment.yml
echo -e "channels:\n - conda-forge\n" > .condarc
- name: Setup Mambaforge
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
python-version: '3.12'
miniforge-variant: Mambaforge
channels: conda-forge
channel-priority: strict
activate-environment: my-env
miniforge-version: latest
condarc-file: .condarc
environment-file: environment.yml
use-mamba: true
- name: Tests
shell: bash -l {0}
run: |
Expand Down
12 changes: 5 additions & 7 deletions .github/workflows/notebooks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,19 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Merge environment
run: |
cp .ci_support/environment.yml environment.yml
tail --lines=+4 .ci_support/environment-notebooks.yml >> environment.yml
echo -e "channels:\n - conda-forge\n" > .condarc
- name: Setup Mambaforge
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
python-version: '3.12'
miniforge-variant: Mambaforge
channels: conda-forge
channel-priority: strict
activate-environment: my-env
miniforge-version: latest
condarc-file: .condarc
environment-file: environment.yml
use-mamba: true
- name: Test
shell: bash -l {0}
run: |
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/pypicheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Conda config
run: echo -e "channels:\n - conda-forge\n" > .condarc
- name: Setup Mambaforge
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
python-version: '3.12'
miniforge-variant: Mambaforge
channels: conda-forge
channel-priority: strict
activate-environment: my-env
miniforge-version: latest
condarc-file: .condarc
environment-file: .ci_support/environment.yml
use-mamba: true
- name: Pip check
shell: bash -l {0}
run: |
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/unittests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,16 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Conda config
shell: bash -l {0}
run: echo -e "channels:\n - conda-forge\n" > .condarc
- name: Setup Mambaforge
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
python-version: ${{ matrix.python-version }}
miniforge-variant: Mambaforge
channels: conda-forge
channel-priority: strict
activate-environment: my-env
miniforge-version: latest
condarc-file: .condarc
environment-file: .ci_support/environment.yml
use-mamba: true
- name: Test
shell: bash -l {0}
timeout-minutes: 30
Expand Down
13 changes: 6 additions & 7 deletions .github/workflows/unittests_old.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Conda config
run: echo -e "channels:\n - conda-forge\n" > .condarc
- name: Setup Mambaforge
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
python-version: '3.9'
miniforge-variant: Mambaforge
channels: conda-forge
channel-priority: strict
activate-environment: my-env
python-version: '3.10'
miniforge-version: latest
condarc-file: .condarc
environment-file: .ci_support/environment-old.yml
use-mamba: true
- name: Test
shell: bash -l {0}
timeout-minutes: 30
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.6.1
rev: v0.6.3
hooks:
- id: ruff
name: ruff lint
Expand Down
10 changes: 5 additions & 5 deletions binder/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ channels:
dependencies:
- aimsgb =1.1.0
- ase =3.23.0
- atomistics =0.1.31
- atomistics =0.1.32
- defusedxml =0.7.1
- h5py =3.11.0
- matplotlib-base =3.9.2
Expand All @@ -13,15 +13,15 @@ dependencies:
- pandas =2.2.2
- phonopy =2.26.6
- pint =0.24.3
- pyiron_base =0.9.12
- pyiron_base =0.10.1
- pyiron_snippets =0.1.4
- pylammpsmpi =0.2.23
- pylammpsmpi =0.2.25
- pyscal3 =3.2.7
- scikit-learn =1.5.1
- scipy =1.14.0
- scipy =1.14.1
- seekpath =2.1.0
- spglib =2.5.0
- structuretoolkit =0.0.27
- structuretoolkit =0.0.28
- pyxtal =0.6.2
- pyiron-data =0.0.30
- sqsgenerator =0.3
Expand Down
16 changes: 7 additions & 9 deletions pyiron_atomistics/atomistics/job/atomistic.py
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,9 @@ def calc_md(
self._generic_input["time_step"] = int(time_step)
self._generic_input.remove_keys(["max_iter"])

def from_dict(self, job_dict):
super().from_dict(job_dict=job_dict)
self._generic_input.from_dict(obj_dict=job_dict["input"]["generic"])
def from_dict(self, obj_dict):
super().from_dict(obj_dict=obj_dict)
self._generic_input.from_dict(obj_dict=obj_dict["input"]["generic"])

def to_dict(self):
job_dict = super(AtomisticGenericJob, self).to_dict()
Expand Down Expand Up @@ -818,14 +818,12 @@ def _structure_to_dict(self):
else:
return None

def _structure_from_dict(self, job_dict):
def _structure_from_dict(self, obj_dict):
if (
"structure" in job_dict["input"].keys()
"structure" in obj_dict["input"].keys()
and self._generic_input["structure"] == "atoms"
):
self.structure = Atoms().from_dict(
atoms_dict=job_dict["input"]["structure"]
)
self.structure = Atoms().from_dict(obj_dict=obj_dict["input"]["structure"])

def _structure_to_hdf(self):
data_dict = self._structure_to_dict()
Expand All @@ -840,7 +838,7 @@ def _structure_from_hdf(self):
):
with self.project_hdf5.open("input/structure") as hdf5_input:
self.structure = Atoms().from_dict(
hdf5_input.read_dict_from_hdf(recursive=True)
obj_dict=hdf5_input.read_dict_from_hdf(recursive=True)
)

def _write_chemical_formular_to_database(self):
Expand Down
2 changes: 1 addition & 1 deletion pyiron_atomistics/atomistics/master/quasi.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,6 @@ def plot_free_energy_volume_temperature(
)
scalarmappaple = matplotlib.cm.ScalarMappable(norm=normalize, cmap=cmap)
scalarmappaple.set_array(temperatures)
cbar = matplotlib.pyplot.colorbar(scalarmappaple)
cbar = matplotlib.pyplot.colorbar(scalarmappaple, ax=axis)
cbar.set_label("Temperature")
return axis
Loading
Loading