Add error message if Murnaghan.plot is called on unfinished jobs #291
Conversation
Pull Request Test Coverage Report for Build 1067316977
💛 - Coveralls |
| if not self.status.finished: | ||
| raise ValueError("Job must be successfully run, before calling this method.") |
There was a problem hiding this comment.
But maybe I want to use the plot method with 10 points if out of my 11 calculation one failed. Meaning I see why you want this while at the same time it might also break the workflow of others.
There was a problem hiding this comment.
In my case it was more that the calculations hadn't finished yet, so energy and volume are not in the HDF yet. What about
| if not self.status.finished: | |
| raise ValueError("Job must be successfully run, before calling this method.") | |
| if not (self.status.finished or self.status.not_converged): | |
| raise ValueError("Job must be successfully run, before calling this method.") |
In case the job aborts, I suppose there's no point in plotting, since there will also be no data in the HDF.
There was a problem hiding this comment.
My bad - we can keep the initial modification - when the collect is successful the status is set to finished https://github.com/pyiron/pyiron_base/blob/master/pyiron_base/master/parallel.py#L458 I mixed it up with my own workflow which is based on pyiron tables.
Just a small QoL fix to fail early.