Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind creator at import #347

Merged
merged 14 commits into from
Sep 27, 2021
Merged

Bind creator at import #347

merged 14 commits into from
Sep 27, 2021

Conversation

liamhuber
Copy link
Member

@liamhuber liamhuber commented Sep 7, 2021

A prototype for how we might dynamically extend the Project class as pyiron submodules get imported.

Depends on pyiron_base#427.

@coveralls
Copy link

coveralls commented Sep 7, 2021

Pull Request Test Coverage Report for Build 1266456968

  • 57 of 57 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 69.759%

Totals Coverage Status
Change from base Build 1265203378: 1.6%
Covered Lines: 11421
Relevant Lines: 16372

💛 - Coveralls

@liamhuber liamhuber marked this pull request as draft September 7, 2021 09:41
@stale
Copy link

stale bot commented Sep 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 22, 2021
@stale stale bot removed the stale label Sep 22, 2021
@liamhuber liamhuber marked this pull request as ready for review September 22, 2021 10:18
@liamhuber liamhuber marked this pull request as draft September 22, 2021 10:19
@liamhuber
Copy link
Member Author

waiting on pyiron_base 0.3.3

@liamhuber liamhuber marked this pull request as ready for review September 23, 2021 12:17
@liamhuber liamhuber merged commit d23b0be into master Sep 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the direct_binding branch September 27, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants