Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support full style without bonds #365

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Support full style without bonds #365

merged 1 commit into from
Sep 23, 2021

Conversation

jan-janssen
Copy link
Member

To support full style in LAMMPS without requiring bonds. To automatically generate water bonds set:

job.interactive_water_bonds = True

@jan-janssen
Support full style without bonds
67d1c99 
To support full style in LAMMPS without requiring bonds. To automatically generate water bonds set:
```
job.interactive_water_bonds = True
```
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1264144459

  • 5 of 10 (50.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 68.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/lammps/interactive.py 5 10 50.0%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/lammps/interactive.py 2 35.54%
Totals Coverage Status
Change from base Build 1259138574: -0.007%
Covered Lines: 11121
Relevant Lines: 16315
💛 - Coveralls

sudarsan-surendralal
sudarsan-surendralal approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@sudarsan-surendralal sudarsan-surendralal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks good to me. I'll already merge this with the interactive notebook branch

@sudarsan-surendralal sudarsan-surendralal merged commit c5409f4 into master Sep 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the style_full_without_bonds branch September 23, 2021 09:16
jan-janssen added a commit that referenced this pull request Sep 24, 2021
@jan-janssen
Merge pull request #368 from pyiron/master
f4e2ae5 
Merge pull request #365 from pyiron/style_full_without_bonds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudarsan-surendralal sudarsan-surendralal sudarsan-surendralal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jan-janssen @coveralls @sudarsan-surendralal