-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Methfessel Paxton default in SPHInX #416
Conversation
Pull Request Test Coverage Report for Build 1444528274
💛 - Coveralls |
There is a danger to setting this as the default. The Methfessel-Paxton scheme is not recommended for semi-conductors and insulators where you could end up with occupancies less than 0 (see the discussion on the VASP wiki). There is no way of knowing if a structure is metallic or not beforehand and therefore wouldn't something like the Fermi/Gaussian type smearing be better? |
But shouldn't we follow the default behaviour in VASP? (cf. this page) |
Generally yes, but in this case, we need to consider the possibility that the VASP default may not be the right option. But I'm not sure. |
ok but I guess it's a bigger problem that SPHInX and VASP have different default settings, isn't it? |
Ah yes, then what you implemented here is correct (both VASP and SPHINX now have the same default parameters). But I guess people working with semiconductors/insulators should be aware of this. |
Since Methfessel-Paxton is now available in SPHInX I made it the default behaviour in pyiron.