Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Methfessel Paxton default in SPHInX #416

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Conversation

samwaseda
Copy link
Member

Since Methfessel-Paxton is now available in SPHInX I made it the default behaviour in pyiron.

@samwaseda samwaseda requested review from jan-janssen, pmrv and sudarsan-surendralal and removed request for jan-janssen November 9, 2021 14:56
@coveralls
Copy link

coveralls commented Nov 9, 2021

Pull Request Test Coverage Report for Build 1444528274

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 69.748%

Totals Coverage Status
Change from base Build 1439958322: 0.03%
Covered Lines: 11422
Relevant Lines: 16376

💛 - Coveralls

@sudarsan-surendralal
Copy link
Member

There is a danger to setting this as the default. The Methfessel-Paxton scheme is not recommended for semi-conductors and insulators where you could end up with occupancies less than 0 (see the discussion on the VASP wiki). There is no way of knowing if a structure is metallic or not beforehand and therefore wouldn't something like the Fermi/Gaussian type smearing be better?

@samwaseda
Copy link
Member Author

But shouldn't we follow the default behaviour in VASP? (cf. this page)

@sudarsan-surendralal
Copy link
Member

sudarsan-surendralal commented Nov 9, 2021

But shouldn't we follow the default behaviour in VASP? (cf. this page)

Generally yes, but in this case, we need to consider the possibility that the VASP default may not be the right option. But I'm not sure.

@samwaseda
Copy link
Member Author

ok but I guess it's a bigger problem that SPHInX and VASP have different default settings, isn't it?

@sudarsan-surendralal
Copy link
Member

ok but I guess it's a bigger problem that SPHInX and VASP have different default settings, isn't it?

Ah yes, then what you implemented here is correct (both VASP and SPHINX now have the same default parameters). But I guess people working with semiconductors/insulators should be aware of this.

@samwaseda samwaseda merged commit 2f41160 into master Nov 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the methfessel-paxton branch November 10, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants