-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some of the structure plotting functions from contrib #710
Conversation
This is code moved from pyiron_contrib
So TrainingContainers plotting interface should inherit from this than? |
Yeah, that's how I was planning it. These plotting functions would be purely concerned with structural data and the training container ones would then only add things related to energies, forces, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea. If some errors occur down the line we should fix them there.
I didn't want to pull in seaborn for just one plot, so I put it in an |
I also remembered to update the change log. :') |
Pull Request Test Coverage Report for Build 2829084886
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
They were previously defined on the
TrainingContainer
over in contrib, but I have added alsodistances
to plot a plain histogram of nearest neighbor distances.Corresponding PR to contrib once this is through.