StructureStorage: do not add extra elements #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously get_structure returned added all elements in the storage to each structure and defined the indices accordingly, even if the structure only contains a subset of these elements. Not all codes can handle this, so I'm restricting this again.
Pull Request Test Coverage Report for Build 3336067739
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously get_structure returned added all elements in the storage to each structure and defined the indices accordingly, even if the structure only contains a subset of these elements. Not all codes can handle this, so I'm restricting this again.
Obsoletes #700 somewhat, but there's still other ways it can be an issue.