Add output files class #1311
Merged
Add output files class #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .ci_support/environment.yml # pyiron_base/jobs/job/util.py # setup.py
Also use a sub test for every line test
job[] is overloaded to perform many functions at once: 1. access to files 2. access to HDF stored data 3. access to child jobs This change adds a new attribute `.files` to `JobCore` to take over function 1 and deprecates methods on the job itself that are connected to this: `list_files` and `tail`.
jan-janssen
added
format_black
|
@pmrv I merged your previous branch into this one and modified it to fulfil your requirements (based on the tests) as well as mine. From my perspective the pull request is now ready to be reviewed. |
jan-janssen
added
format_black
pmrv
approved these changes
Feb 7, 2024
| raise AttributeError(item) from None | ||
|
|
||
|
|
||
| class File(str): |
There was a problem hiding this comment.
Suggested change
| class File(str): | |
| class File: | |
| __slots__ = ("_path",) | |
| def __init__(self, path: str): | |
| """ | |
| Wrap a file. | |
| Args: | |
| path (str): path to file | |
| """ | |
| self._path = path |
There was a problem hiding this comment.
We not actually using any string functionality here and I'd rather not let people accidentally perform string operations on this object.
There was a problem hiding this comment.
The reason why I would like to keep the string part in, is that then I can use os.path.join() on the object, this is what I need to access the path.
Comment on lines
+120
to
+121
| working_directory=os.path.dirname(self), | ||
| file_name=os.path.basename(self), |
There was a problem hiding this comment.
Suggested change
| working_directory=os.path.dirname(self), | |
| file_name=os.path.basename(self), | |
| working_directory=os.path.dirname(self._path), | |
| file_name=os.path.basename(self._path), |
See above.
Co-authored-by: Marvin Poul <[email protected]>
Co-authored-by: Marvin Poul <[email protected]>
Co-authored-by: Marvin Poul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In comparison to the previous work in #969 this pull request only lists the file paths for the files in the working directory.
Alternatively, we could also consider combining both pull requests.