Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate relocate_hdf #901

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Separate relocate_hdf #901

merged 3 commits into from
Nov 17, 2022

Conversation

samwaseda
Copy link
Member

Separate the rewriting of the hdf address, in order for other jobs to be able to intervene (e.g. the new SPHInX implementation that requires an extra loading of lazy mode for the input)

@samwaseda samwaseda added the enhancement New feature or request label Nov 16, 2022
@samwaseda samwaseda added the integration Start the integration tests with pyiron_atomistics/contrib for this PR label Nov 16, 2022
@samwaseda samwaseda changed the title Separate rewrite_hdf Separate relocate_hdf Nov 16, 2022
@pmrv
Copy link
Contributor

pmrv commented Nov 16, 2022

If I understand this correctly, the original code works because job.project_hdf5 points into the HDF file of the master job and this then resets it to point into its own file. Is this correct? If so, I would prefer to call this reset_hdf5 or something like this. Otherwise lgtm.

@samwaseda
Copy link
Member Author

samwaseda commented Nov 16, 2022

If I understand this correctly, the original code works because job.project_hdf5 points into the HDF file of the master job and this then resets it to point into its own file. Is this correct? If so, I would prefer to call this reset_hdf5 or something like this. Otherwise lgtm.

Well, I would rather say the original one works because the content of the HDF file is (supposed to be) stored in the job attributes (such as job.input) when the child job is loaded, and therefore the job doesn't care about the HDF file anymore. Of course this is not the case for the lazy loading.

@samwaseda samwaseda merged commit 794e613 into master Nov 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the rewrite_project_hdf branch November 17, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request integration Start the integration tests with pyiron_atomistics/contrib for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants